Use vectorize instead of jit in EOS #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of the
@jit
numba decorator with the@vectorize
decorator in the eos calculation. According to the numba docs,@vectorize
is the recommended way to create a numpy ufunc, which I believe is what is wanted here.The speedup on my laptop is about 3x:
I also removed what seems to be an unnecessary if clause regarding
xarray.apply_ufunc
.